nastra commented on code in PR #9940:
URL: https://github.com/apache/iceberg/pull/9940#discussion_r1665211346

##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -28,6 +28,10 @@ info:
   description:
     Defines the specification for the first version of the REST Catalog API.
     Implementations should ideally support both Iceberg table specs v1 and v2, 
with priority given to v2.
+
+    This API uses capability tags to describe optional functionality.
+    In order to support a particular capability, a server is required to 
implement all endpoints grouped under a particular tag.

Review Comment:
   If it helps, then I can change this from `required` to `should implement` 
and servers only partially implementing a capability can highlight this through 
docs or other meaningful ways, but rather than saying `should implement` the 
server should be explicit and throw a 501 (not implemented) in that case. I'll 
update the wording here to make this clearer.
   
   As I mentioned in 
https://lists.apache.org/thread/qq9bfqtx9yoqb3goj3zvjsgwt8hotvj9 capabilities 
should rather be coarse-grained and an easy way for a client to understand what 
capabilities a server support. 
   Introducing `table-read` / `table-management` / `table-write` / 
`table-delete` seems to be rather going in a finer grained direction and I 
don't think we want to end up having a 1:1 mapping between a single endpoint 
and a single capability.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to