jackye1995 commented on code in PR #9940:
URL: https://github.com/apache/iceberg/pull/9940#discussion_r1664421615
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -191,7 +220,8 @@ paths:
get:
tags:
- - Catalog API
+ - tables
+ - views
Review Comment:
hmm, this seems like a problem to me. I want to avoid overlapping tags if
possible, because when this happens, you need to know "if I support tables, not
views, do I support this API?". The answer here might be a simple yes, but for
complex capabilities, it might become a case by case thing and things become
really complex. What do you think?
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -191,7 +220,8 @@ paths:
get:
tags:
- - Catalog API
+ - tables
+ - views
Review Comment:
hmm, this seems like a problem to me. I want to avoid overlapping tags if
possible, because when this happens, you need to know "if I support tables, not
views, do I support this API?". The answer here might be a simple yes, but for
complex capabilities, it might become a case by case analysis and things become
really complex. What do you think?
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -61,12 +65,26 @@ security:
- OAuth2: [catalog]
- BearerAuth: []
+# Capability tags describe optional functionality and are used to group
endpoints together.
+# In order to support a particular capability, a server is required to
implement all endpoints grouped under a particular tag.
+tags:
+ - name: tables
+ description: Required as part of table support
+ - name: views
+ description: Required as part of view support
+ - name: remote-signing
Review Comment:
if we consider this as a capability, do we also consider
`credentials-vending` a capability? I think we should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
