pvary commented on code in PR #10565:
URL: https://github.com/apache/iceberg/pull/10565#discussion_r1665110520
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java:
##########
@@ -79,7 +79,11 @@ public static Object convertConstant(Type type, Object
value) {
* the arity check.
*/
public static RowData clone(
- RowData from, RowData reuse, RowType rowType, TypeSerializer[]
fieldSerializers) {
+ RowData from,
Review Comment:
I feel that performance degradation is acceptable for the deprecated methods
if it is justified otherwise. The number of the duplicated lines seems high
enough for me to try to avoid them.
The users could always do the caching of the getters themselves, or find
another solution soon, since we remove the deprecated methods regularly.
WDYT?
Also CC-ed, @stevenzwu, who might be also interested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
