fengjiajie commented on code in PR #10565:
URL: https://github.com/apache/iceberg/pull/10565#discussion_r1665086491
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java:
##########
@@ -79,7 +79,11 @@ public static Object convertConstant(Type type, Object
value) {
* the arity check.
*/
public static RowData clone(
- RowData from, RowData reuse, RowType rowType, TypeSerializer[]
fieldSerializers) {
+ RowData from,
Review Comment:
Thanks for the reminder! I've added the original function below. The reason
I didn't directly use the new function is that it requires FieldGetter for all
fields, while the old function only needs to construct FieldGetter for fields
with values. Constructing FieldGetter for all fields might negatively impact
performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
