pvary commented on code in PR #10565:
URL: https://github.com/apache/iceberg/pull/10565#discussion_r1664640913
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/RowDataRecordFactory.java:
##########
@@ -40,6 +42,14 @@ static TypeSerializer[] createFieldSerializers(RowType
rowType) {
.toArray(TypeSerializer[]::new);
}
+ static RowData.FieldGetter[] createFieldGetters(RowType rowType) {
+ RowData.FieldGetter[] fieldGetters = new
RowData.FieldGetter[rowType.getFieldCount()];
+ for (int i = 0; i < rowType.getFieldCount(); ++i) {
+ fieldGetters[i] = RowData.createFieldGetter(rowType.getTypeAt(i), i);
+ }
+ return fieldGetters;
Review Comment:
Nit: newline after the end of a block, like
```
}
return fieldGetters;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
