findepi commented on code in PR #10543:
URL: https://github.com/apache/iceberg/pull/10543#discussion_r1650894264
##########
common/src/main/java/org/apache/iceberg/common/DynMethods.java:
##########
@@ -161,6 +161,8 @@ private BoundMethod(UnboundMethod method, Object receiver) {
this.receiver = receiver;
}
+ /** @deprecated since 1.6.0, will be removed in 1.7.0 */
Review Comment:
My thinking is that any variant needed in the future is very easy to add
when needed and doesn't necessitate keeping current-dead-code around. Removing
dead code clears the picture and open eyes on further simplifications. Does
this make sense? BTW recently, i was starring at a pretty complex class that
was negatively impacted by some other changes only to eventually realize it's
used only in its own tests and can simply be deleted. What a relief.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
