Fokko commented on code in PR #10543:
URL: https://github.com/apache/iceberg/pull/10543#discussion_r1680535090
##########
common/src/main/java/org/apache/iceberg/common/DynMethods.java:
##########
@@ -161,6 +161,8 @@ private BoundMethod(UnboundMethod method, Object receiver) {
this.receiver = receiver;
}
+ /** @deprecated since 1.6.0, will be removed in 1.7.0 */
Review Comment:
What I'm trying to say is that we should mark [this
`invokeChecked`](https://github.com/apache/iceberg/blob/ff7e833c64806915af47499cbecf926ecdc875ee/common/src/main/java/org/apache/iceberg/common/DynMethods.java#L55)
as deprecated as well. Since that's only being used from
[`invoke`](https://github.com/apache/iceberg/blob/ff7e833c64806915af47499cbecf926ecdc875ee/common/src/main/java/org/apache/iceberg/common/DynMethods.java#L72).
This way we can remove `invokeChecked` completely from the public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
