findepi commented on code in PR #10501:
URL: https://github.com/apache/iceberg/pull/10501#discussion_r1642311977
##########
.palantir/revapi.yml:
##########
@@ -1024,6 +1024,38 @@ acceptedBreaks:
old: "class org.apache.iceberg.types.Types.NestedField"
new: "class org.apache.iceberg.types.Types.NestedField"
justification: "new Constructor added"
+ org.apache.iceberg:iceberg-core:
Review Comment:
I think in Trino we somehow avoid the need for rev-api exclusions, because
we instructed it to watch for `@Deprecated` annotation. However, we would need
something more elaborate to take into account the text associated with the
`@deprecated` javadoc, which announces the version in which the given element
is supposed to disappear. I don't know whether rev-api can already look at the
javadoc text, but it definitely would be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
