nastra commented on code in PR #10501:
URL: https://github.com/apache/iceberg/pull/10501#discussion_r1642245973
##########
.palantir/revapi.yml:
##########
@@ -1024,6 +1024,38 @@ acceptedBreaks:
old: "class org.apache.iceberg.types.Types.NestedField"
new: "class org.apache.iceberg.types.Types.NestedField"
justification: "new Constructor added"
+ org.apache.iceberg:iceberg-core:
+ - code: "java.method.visibilityReduced"
+ old: "method void
org.apache.iceberg.encryption.PlaintextEncryptionManager::<init>()"
+ new: "method void
org.apache.iceberg.encryption.PlaintextEncryptionManager::<init>()"
+ justification: "Deprecations for 1.6.0 release"
+ - code: "java.element.noLongerDeprecated"
+ old: "method void
org.apache.iceberg.encryption.PlaintextEncryptionManager::<init>()"
+ new: "method void
org.apache.iceberg.encryption.PlaintextEncryptionManager::<init>()"
+ justification: "Constructor became private as part of deprecations
cleanup for 1.6.0 release"
+ - code: "java.element.noLongerDeprecated"
+ old: "method void
org.apache.iceberg.rest.auth.OAuth2Util.AuthSession::<init>(java.util.Map<java.lang.String,\
+ \ java.lang.String>, java.lang.String, java.lang.String,
java.lang.String,\
+ \ java.lang.String)"
+ new: "method void
org.apache.iceberg.rest.auth.OAuth2Util.AuthSession::<init>(java.util.Map<java.lang.String,\
+ \ java.lang.String>, org.apache.iceberg.rest.auth.AuthConfig)"
+ justification: "This is actually a removal of a deprecated constructor
as part\
Review Comment:
```suggestion
justification: "Deprecations for 1.6.0 release"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
