ZENOTME commented on code in PR #401: URL: https://github.com/apache/iceberg-rust/pull/401#discussion_r1638068933
########## crates/iceberg/src/scan.rs: ########## @@ -503,17 +544,36 @@ pub struct FileScanTask { start: u64, #[allow(dead_code)] length: u64, + project_field_id: Vec<usize>, Review Comment: Good point! I think we can use i32 here as the same of https://github.com/apache/iceberg-rust/blob/ffafe1560b75158fa17ae1c49e5955e4f2f52402/crates/iceberg/src/spec/datatypes.rs#L504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org