sdd commented on code in PR #401:
URL: https://github.com/apache/iceberg-rust/pull/401#discussion_r1637602580
##########
crates/iceberg/src/scan.rs:
##########
@@ -503,17 +544,36 @@ pub struct FileScanTask {
start: u64,
#[allow(dead_code)]
length: u64,
+ project_field_id: Vec<usize>,
Review Comment:
Should this be a `u64` or `u32` rather than a `usize`? Especially if these
are intended to be serialized, we'd want to ensure we don't break things when
serializing on a 64 bit arch and then deserializing on 32-bit for example.
Probably should call this `projected_field_ids` as well rather than
`project_field_id`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
