nastra commented on code in PR #10478:
URL: https://github.com/apache/iceberg/pull/10478#discussion_r1639879685
##########
settings.gradle:
##########
@@ -72,6 +72,7 @@ project(':open-api').name = 'iceberg-open-api'
if (null != System.getProperty("allVersions")) {
System.setProperty("flinkVersions", System.getProperty("knownFlinkVersions"))
+ System.setProperty("scalaVersions", System.getProperty("knownScalaVersions"))
Review Comment:
the purpose when I added `allVersions` was to reflect all module versions
that we release but I see how this can cause confusion with Scala versions
(which only apply for Flink and Spark).
I still don't think we can blindly just include all Scala versions, because
they would only apply across Spark modules and will most likely cause issues
with Flink modules when you pass Scala 2.13 when building Flink versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
