findepi commented on code in PR #10478:
URL: https://github.com/apache/iceberg/pull/10478#discussion_r1639601085
##########
settings.gradle:
##########
@@ -72,6 +72,7 @@ project(':open-api').name = 'iceberg-open-api'
if (null != System.getProperty("allVersions")) {
System.setProperty("flinkVersions", System.getProperty("knownFlinkVersions"))
+ System.setProperty("scalaVersions", System.getProperty("knownScalaVersions"))
Review Comment:
should we then document why scala is left out and rename `allVersions` to
avoid people assuming something incorrectly?
for exemple one could assume that `./gradlew -DallVersions=true
spotlessApply` will reformat all of the code, but i don't think it would
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
