stevenzwu commented on code in PR #10457:
URL: https://github.com/apache/iceberg/pull/10457#discussion_r1630345753
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/AggregatedStatistics.java:
##########
@@ -35,28 +35,28 @@ class AggregatedStatistics implements Serializable {
private final long checkpointId;
private final StatisticsType type;
private final Map<SortKey, Long> keyFrequency;
- private final SortKey[] rangeBounds;
+ private final SortKey[] keySamples;
Review Comment:
I can definitely agree that it can be confusing. I also thought about it. We
need to duplicate the serializer too. That was the main reason that I didn't go
that route. I can make the change if you think it is better to separate them
out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
