pvary commented on code in PR #10457:
URL: https://github.com/apache/iceberg/pull/10457#discussion_r1630169892
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/shuffle/TestAggregatedStatisticsTracker.java:
##########
@@ -246,7 +254,14 @@ public void receiveCompletedStatisticsEvent(StatisticsType
type) {
CHAR_KEYS.get("a"), 3L,
CHAR_KEYS.get("b"), 3L));
} else {
-
assertThat(completedStatistics.rangeBounds()).containsExactly(CHAR_KEYS.get("a"));
+ assertThat(completedStatistics.keySamples())
+ .containsExactly(
+ CHAR_KEYS.get("a"),
+ CHAR_KEYS.get("b"),
+ CHAR_KEYS.get("b"),
+ CHAR_KEYS.get("a"),
+ CHAR_KEYS.get("a"),
Review Comment:
So the key samples are not ordered, just randomly selected samples from the
incoming records?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
