pvary commented on code in PR #10457:
URL: https://github.com/apache/iceberg/pull/10457#discussion_r1632828545
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/AggregatedStatistics.java:
##########
@@ -35,28 +35,28 @@ class AggregatedStatistics implements Serializable {
private final long checkpointId;
private final StatisticsType type;
private final Map<SortKey, Long> keyFrequency;
- private final SortKey[] rangeBounds;
+ private final SortKey[] keySamples;
Review Comment:
Reading through the code again, I'm more-and-more convinced, that we have 2
different objects here:
- RangeBounds (former global statistics) - key-values of the weights used by
the partitioner with hash
- Statistics (former completed statistics) - Sketch or Map without hash, but
full of data
I think we are just confusing them because of historical reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
