pvary commented on code in PR #10457:
URL: https://github.com/apache/iceberg/pull/10457#discussion_r1630149920
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/AggregatedStatistics.java:
##########
@@ -35,28 +35,28 @@ class AggregatedStatistics implements Serializable {
private final long checkpointId;
private final StatisticsType type;
private final Map<SortKey, Long> keyFrequency;
- private final SortKey[] rangeBounds;
+ private final SortKey[] keySamples;
Review Comment:
Would it be better to have a separate class for global stat, and aggregate
stat? It's a bit late here, and it's a bit hard to follow when the keys
keySamples are actually range bounds, and when they contain the full data...
Maybe tomorrow it will be easier to follow 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
