anuragmantri commented on PR #10434: URL: https://github.com/apache/iceberg/pull/10434#issuecomment-2146255190
Thanks @Fokko and @flyrain - I think we should keep the inheritance and remove the duplicates in sub types. I updated this PR to do that. @flyrain this pattern of **discriminator field present also as child field** is used in 3 other places - ContentFile: data-file, position-delete-file etc - BaseUpdate: update-uuid, upgrade-format-version etc - ViewRequirement: assert-view-uuid Should we remove child fields and move the descriptor fields to parent all these places to be consistent? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
