flyrain commented on PR #10434: URL: https://github.com/apache/iceberg/pull/10434#issuecomment-2146160956
We should go either with inheritance by using `AllOf`, or with `[discriminator](https://swagger.io/docs/specification/data-models/inheritance-and-polymorphism/)` in open API spec, but not both. We don't have to use inheritance here, but I'm OK with it. If we choose the inheritance, we will also need to remove the type properties in each subclasses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
