Fokko commented on PR #10434:
URL: https://github.com/apache/iceberg/pull/10434#issuecomment-2146090622
Thanks for raising this @anuragmantri
Looking at the changes in the code, it will remove the inheritance:
```python
diff --git a/open-api/rest-catalog-open-api.py
b/open-api/rest-catalog-open-api.py
index e13aeee..46c7eca 100644
--- a/open-api/rest-catalog-open-api.py
+++ b/open-api/rest-catalog-open-api.py
@@ -361,10 +361,10 @@ class RemovePartitionStatisticsUpdate(BaseUpdate):
class TableRequirement(BaseModel):
- type: str
+ pass
-class AssertCreate(TableRequirement):
+class AssertCreate(BaseModel):
"""
The table must not already exist; used for create transactions
"""
@@ -372,7 +372,7 @@ class AssertCreate(TableRequirement):
type: Literal['assert-create']
-class AssertTableUUID(TableRequirement):
+class AssertTableUUID(BaseModel):
"""
The table UUID must match the requirement's `uuid`
"""
@@ -381,7 +381,7 @@ class AssertTableUUID(TableRequirement):
uuid: str
-class AssertRefSnapshotId(TableRequirement):
+class AssertRefSnapshotId(BaseModel):
"""
The table branch or tag identified by the requirement's `ref` must
reference the requirement's `snapshot-id`; if `snapshot-id` is `null` or
missing, the ref must not already exist
"""
@@ -391,7 +391,7 @@ class AssertRefSnapshotId(TableRequirement):
snapshot_id: int = Field(..., alias='snapshot-id')
-class AssertLastAssignedFieldId(TableRequirement):
+class AssertLastAssignedFieldId(BaseModel):
"""
The table's last assigned column id must match the requirement's
`last-assigned-field-id`
"""
@@ -400,7 +400,7 @@ class AssertLastAssignedFieldId(TableRequirement):
last_assigned_field_id: int = Field(..., alias='last-assigned-field-id')
-class AssertCurrentSchemaId(TableRequirement):
+class AssertCurrentSchemaId(BaseModel):
"""
The table's current schema id must match the requirement's
`current-schema-id`
"""
@@ -409,7 +409,7 @@ class AssertCurrentSchemaId(TableRequirement):
current_schema_id: int = Field(..., alias='current-schema-id')
-class AssertLastAssignedPartitionId(TableRequirement):
+class AssertLastAssignedPartitionId(BaseModel):
"""
The table's last assigned partition id must match the requirement's
`last-assigned-partition-id`
"""
@@
-4[18](https://github.com/apache/iceberg/actions/runs/9356980269/job/25755651734?pr=10434#step:7:19),7
+418,7 @@ class AssertLastAssignedPartitionId(TableRequirement):
last_assigned_partition_id: int = Field(...,
alias='last-assigned-partition-id')
-class AssertDefaultSpecId(TableRequirement):
+class AssertDefaultSpecId(BaseModel):
"""
The table's default spec id must match the requirement's
`default-spec-id`
"""
@@
-4[27](https://github.com/apache/iceberg/actions/runs/9356980269/job/25755651734?pr=10434#step:7:28),7
+427,7 @@ class AssertDefaultSpecId(TableRequirement):
default_spec_id: int = Field(..., alias='default-spec-id')
-class AssertDefaultSortOrderId(TableRequirement):
+class AssertDefaultSortOrderId(BaseModel):
"""
The table's default sort order id must match the requirement's
`default-sort-order-id`
"""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
