rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1586505918


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2106,6 +2210,32 @@ components:
           items:
             $ref: '#/components/schemas/PartitionStatisticsFile'
 
+    PlanTask:
+      description:
+        An opaque JSON object that contains information provided by the REST 
server
+        to be utilized by clients for distributed table scan planning; should 
be supplied
+        as is for input in `PlanTable` operation.
+      type: object
+
+    FileScanTask:
+      type: object
+      required:
+        - data-file
+      properties:
+        data-file:
+          $ref: '#/components/schemas/DataFile'
+        delete-files:
+          oneOf:

Review Comment:
   @danielcweeks @rdblue  So to confirm a list of `delete-files` can have a mix 
of `positional` deleteFile and `equality` deleteFiles? I thought it can only be 
a list only of positional deletes, or a list of equality deletes
   
   When checking the java interface for just the `DeleteFile` 
https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/DeleteFile.java#L24
 which is based on `ContentFile`, it seems a single file can only have one type 
https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/ContentFile.java#L42
 
   ```
   one of DATA, POSITION_DELETES, or EQUALITY_DELETES
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to