amogh-jahagirdar commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1618157387
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2106,6 +2210,32 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
+ PlanTask:
+ description:
+ An opaque JSON object that contains information provided by the REST
server
+ to be utilized by clients for distributed table scan planning; should
be supplied
+ as is for input in `PlanTable` operation.
+ type: object
+
+ FileScanTask:
+ type: object
+ required:
+ - data-file
+ properties:
+ data-file:
+ $ref: '#/components/schemas/DataFile'
+ delete-files:
+ oneOf:
Review Comment:
The list in this response representation is the list of delete files that
need to be applied for the given data file in a given task.
That list can have both position and equality deletes. The java
representation being referred to is just for a single instance of a delete
file, but certainly there can be mutiple position + equality deletes that need
to be applied to a single data file in a task. I'd expect the task to have both
of those since it's required for a correct reading of a table.
E.g. There can be Data File A, and then Position Delete File which deletes
a row in Data File A, and then also equality delete can be applied which is
relevant for some rows in Data File A. The FileScanTask should have data file 1
be the data file, and a List containing both the position delete and equality
delete.
So yeah I think oneOf is not correct here; we'll either want to
1.) see if there's some other construct to help us define a list where the
entries can be a mix of both data and delete files
Or
2.) Define separate lists for equality and position deletes.
I'd prefer 1 but I'm not really familiar enough yet with the open API syntax
to define that (can you define a common delete file type, have position and
equality deletes extend that type, and the list is defined with the common
type?); worth looking into that first though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
