ludlows commented on code in PR #10188: URL: https://github.com/apache/iceberg/pull/10188#discussion_r1579048510
########## mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ########## @@ -111,8 +111,15 @@ public void configureTableJobProperties(TableDesc tableDesc, Map<String, String> // @Override public void configureInputJobCredentials(TableDesc tableDesc, Map<String, String> secrets) {} + private void setCommonJobConf(JobConf jobConf) { Review Comment: hi @pvary , thanks for your comments. I have adapted the code to make sure that the setting includes both the old values and the `hive.io.file.readcolumn.names,hive.io.file.readcolumn.ids`. do you have any further sugguestions? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org