amogh-jahagirdar commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1581695111
##########
core/src/main/java/org/apache/iceberg/ClientPoolImpl.java:
##########
@@ -56,26 +69,38 @@ public <R> R run(Action<R, C, E> action, boolean retry)
throws E, InterruptedExc
C client = get();
try {
return action.run(client);
-
} catch (Exception exc) {
- if (retry && isConnectionException(exc)) {
Review Comment:
Good catch, I was getting lucky in the `testNoRetryingWhenDisabled` I added
since the retries I passed in was 0. If the flag is false we should never retry
.
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -40,6 +40,8 @@ final class JdbcUtil {
// property to control if view support is added to the existing database
static final String SCHEMA_VERSION_PROPERTY = JdbcCatalog.PROPERTY_PREFIX +
"schema-version";
+ static final String RETRYABLE_STATUS_CODES = "retryable_status_codes";
Review Comment:
I don't think so , looking at
https://iceberg.apache.org/docs/nightly/jdbc/?h=jdbc#iceberg-jdbc-integration
The properties which are prefixed with "jdbc" look to be specifically for
configuring the JDBC connection url, like user,password, ssl etc. These are
standard options when establishing a JDBC connection.
What we're trying to do here is independent of the JDBC connection URL and
more like a typical catalog property.
I do see that we have strict-mode and schema-version catalog properties
which kind of break this pattern since those aren't relevant for the JDBC
connection URL, but I'm not sure we want to keep following that since it does
seem like the original intention of the prefix was pretty clear on having it be
for the connection URL. cc @jbonofre if you have a take on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
