pvary commented on code in PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#discussion_r1579208675
##########
core/src/main/java/org/apache/iceberg/io/SortedPosDeleteWriter.java:
##########
@@ -59,20 +60,58 @@ class SortedPosDeleteWriter<T> implements
FileWriter<PositionDelete<T>, DeleteWr
OutputFileFactory fileFactory,
FileFormat format,
StructLike partition,
- long recordsNumThreshold) {
+ long recordsNumThreshold,
+ DeleteGranularity deleteGranularity) {
this.appenderFactory = appenderFactory;
this.fileFactory = fileFactory;
this.format = format;
this.partition = partition;
this.recordsNumThreshold = recordsNumThreshold;
+ this.deleteGranularity = deleteGranularity;
+ }
+
+ SortedPosDeleteWriter(
Review Comment:
These constructors are not utilised by our code (or only by tests), but kept
them for compatibility reasons.
Do we need them? Are they part of the API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
