pvary commented on code in PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#discussion_r1577753275
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java:
##########
@@ -56,7 +58,8 @@ abstract class BaseDeltaTaskWriter extends
BaseTaskWriter<RowData> {
Schema schema,
RowType flinkSchema,
List<Integer> equalityFieldIds,
- boolean upsert) {
+ boolean upsert,
+ DeleteGranularity deleteGranularity) {
Review Comment:
I think that in most cases we want to use FILE granularity, but we found a
case when Flink might ending up writing multiple delete files with FILE
granularity - when there are big writes, and the data writer rolls. In this
case we might have to create multiple delete files for a single commit. This
might be undesirable for some users, so I have kept the option for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
