pvary commented on code in PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#discussion_r1579204149
##########
core/src/main/java/org/apache/iceberg/io/SortedPosDeleteWriter.java:
##########
@@ -174,20 +208,21 @@ private void flushDeletes() {
} catch (IOException e) {
setFailure(e);
throw new UncheckedIOException(
- "Failed to write the sorted path/pos pairs to pos-delete file: "
- + outputFile.encryptingOutputFile().location(),
Review Comment:
Adding the file location would require some confusing code, like:
- Adding a local attribute to the class `lastOutputFile`
- Updating this attribute in `createWriter`
- We need to assume that if there is an error in
`FileScopedPositionDeleteWriter` it is always with the last opened writer -
which is true, but I am not sure we want to build on that
I think this is more confusing than what it worth to have the filename in
the exception message, but I am open to discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
