epgif commented on code in PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#discussion_r1570983709
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##########
@@ -564,6 +575,7 @@ private static String sanitizeDate(int days, int today) {
return "(date)";
}
+ // TODO(epg): `now` is millisecond resolution; shouldn't this be too?
Review Comment:
Done.
##########
api/src/main/java/org/apache/iceberg/expressions/Literals.java:
##########
@@ -515,6 +548,21 @@ public <T> Literal<T> to(Type type) {
return (Literal<T>) new TimestampLiteral(timestampMicros);
}
+ case TIMESTAMP_NANO:
+ if (((Types.TimestampNanoType) type).shouldAdjustToUTC()) {
+ long timestampNanos =
+ ChronoUnit.NANOS.between(
+ EPOCH, OffsetDateTime.parse(value(),
DateTimeFormatter.ISO_DATE_TIME));
+ return (Literal<T>) new TimestampNanoLiteral(timestampNanos);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
