rdblue commented on code in PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#discussion_r1558327213
##########
api/src/main/java/org/apache/iceberg/transforms/SortOrderVisitor.java:
##########
@@ -84,22 +84,16 @@ static <R> List<R> visit(SortOrder sortOrder,
SortOrderVisitor<R> visitor) {
results.add(
visitor.truncate(
sourceName, field.sourceId(), width, field.direction(),
field.nullOrder()));
- } else if (transform == Dates.YEAR
- || transform == Timestamps.YEAR
- || transform instanceof Years) {
+ } else if ("year".equalsIgnoreCase(transform.toString())) {
Review Comment:
Let's avoid string comparison here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
