epgif commented on code in PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#discussion_r1570987468
##########
api/src/main/java/org/apache/iceberg/transforms/Timestamps.java:
##########
@@ -112,11 +180,11 @@ public boolean satisfiesOrderOf(Transform<?, ?> other) {
}
if (other instanceof Timestamps) {
- // test the granularity, in hours. hour(ts) => 1 hour, day(ts) => 24
hours, and hour satisfies
- // the order of day
+ // test the granularity, in hours. hour(ts) => 1 hour, day(ts) => 24
hours, and
+ // hour satisfies the order of day
Review Comment:
Reverted.
##########
api/src/main/java/org/apache/iceberg/transforms/Timestamps.java:
##########
@@ -184,13 +252,25 @@ public String toHumanString(Type outputType, Integer
value) {
case HOURS:
return TransformUtil.humanHour(value);
default:
- throw new UnsupportedOperationException("Unsupported time unit: " +
granularity);
+ throw new UnsupportedOperationException("Unsupported time unit: " +
apply.resultTypeUnit);
}
}
@Override
public String toString() {
- return name;
Review Comment:
Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
