nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1559611564
##########
core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java:
##########
@@ -34,7 +34,7 @@ public class TestListNamespacesResponse extends
RequestResponseTestBase<ListName
@Test
public void testRoundTripSerDe() throws JsonProcessingException {
- String fullJson = "{\"namespaces\":[[\"accounting\"],[\"tax\"]]}";
+ String fullJson =
"{\"namespaces\":[[\"accounting\"],[\"tax\"]],\"next-page-token\":null}";
Review Comment:
Older clients won't send this field, so I think we want to keep how the JSON
was here for backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
