danielcweeks commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1558551506
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List<TableIdentifier> listTables(SessionContext context, Namespace
ns) {
checkNamespaceIsValid(ns);
+ Map<String, String> queryParams = Maps.newHashMap();
+ List<TableIdentifier> tables = Lists.newArrayList();
+ String pageToken = "";
+ if (restPageSize != null) {
+ queryParams.put("pageToken", pageToken);
+ queryParams.put("pageSize", restPageSize);
+ }
+ do {
+ ListTablesResponse response =
+ client.get(
+ paths.tables(ns),
+ queryParams,
+ ListTablesResponse.class,
+ headers(context),
+ ErrorHandlers.namespaceErrorHandler());
+ pageToken = response.nextPageToken();
Review Comment:
I don't think we're updating the `pageToken` value properly for subsequent
requests. We capture it here, but it needs to be set as the query param for
the next invocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
