rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1558307800
##########
core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java:
##########
@@ -83,6 +83,23 @@ public void testBuilderDoesNotCreateInvalidObjects() {
.hasMessage("Invalid namespace: null");
}
+ @Test
+ public void testWithNullPaginationToken() {
+ ListNamespacesResponse response =
+
ListNamespacesResponse.builder().addAll(NAMESPACES).nextPageToken(null).build();
+ Assertions.assertThat(response.nextPageToken()).isNull();
+ Assertions.assertThat(response.namespaces()).isEqualTo(NAMESPACES);
+ }
+
+ @Test
+ public void testWithPaginationToken() {
Review Comment:
will add this
##########
core/src/test/java/org/apache/iceberg/rest/responses/TestListTablesResponse.java:
##########
@@ -105,6 +105,23 @@ public void testBuilderDoesNotCreateInvalidObjects() {
.hasMessage("Invalid table identifier: null");
}
+ @Test
+ public void testWithNullPaginationToken() {
+ ListTablesResponse response =
+
ListTablesResponse.builder().addAll(IDENTIFIERS).nextPageToken(null).build();
+ Assertions.assertThat(response.nextPageToken()).isNull();
+ Assertions.assertThat(response.identifiers()).isEqualTo(IDENTIFIERS);
+ }
+
+ @Test
+ public void testWithPaginationToken() {
Review Comment:
will add this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
