amogh-jahagirdar commented on code in PR #10026:
URL: https://github.com/apache/iceberg/pull/10026#discussion_r1538289522
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##########
@@ -218,6 +218,44 @@ public void testRewriteDataFilesWithZOrder() {
assertEquals("Should have expected rows", expectedRows, sql("SELECT * FROM
%s", tableName));
}
+ @Test
+ public void testRewriteDataFilesWithZOrderNullBinaryColumn() {
Review Comment:
Makes sense, I went back and forth on the same thing, but then I went ahead
with adding the procedure test just to make sure we're covered in case for
whatever reason down the line, the procedure class stops using the Util class
or something. I'll leave it as is for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
