RussellSpitzer commented on code in PR #10026:
URL: https://github.com/apache/iceberg/pull/10026#discussion_r1536007907
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##########
@@ -218,6 +218,44 @@ public void testRewriteDataFilesWithZOrder() {
assertEquals("Should have expected rows", expectedRows, sql("SELECT * FROM
%s", tableName));
}
+ @Test
+ public void testRewriteDataFilesWithZOrderNullBinaryColumn() {
Review Comment:
I would probably skip the procedure tests. I think the Util test covers
this. If you did want to add a deeper integration test I would add it in the
Action but I don't think that's required.
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##########
@@ -218,6 +218,44 @@ public void testRewriteDataFilesWithZOrder() {
assertEquals("Should have expected rows", expectedRows, sql("SELECT * FROM
%s", tableName));
}
+ @Test
+ public void testRewriteDataFilesWithZOrderNullBinaryColumn() {
Review Comment:
I would probably skip the procedure tests. I think the Util test covers this
well enough. If you did want to add a deeper integration test I would add it in
the Action but I don't think that's required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
