nastra commented on code in PR #10026:
URL: https://github.com/apache/iceberg/pull/10026#discussion_r1537421016
##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##########
@@ -261,6 +261,44 @@ public void testRewriteDataFilesWithZOrder() {
assertEquals("Should have expected rows", expectedRows, sql("SELECT * FROM
%s", tableName));
}
+ @Test
+ public void testRewriteDataFilesWithZOrderNullBinaryColumn() {
+ sql("CREATE TABLE %s (c1 int, c2 string, c3 binary) USING iceberg",
tableName);
+
+ for (int i = 0; i < 5; i++) {
+ sql("INSERT INTO %s values (1, 'foo', null), (2, 'bar', null)",
tableName);
+ }
+
+ List<Object[]> output =
+ sql(
+ "CALL %s.system.rewrite_data_files(table => '%s', "
+ + "strategy => 'sort', sort_order => 'zorder(c2,c3)')",
+ catalogName, tableIdent);
+
+ assertEquals(
+ "Action should rewrite 10 data files and add 1 data files",
+ row(10, 1),
+ Arrays.copyOf(output.get(0), 2));
+ assertThat(output.get(0)).hasSize(4);
+ assertThat(output.get(0)[2])
+ .isInstanceOf(Long.class)
+
.isEqualTo(Long.valueOf(snapshotSummary().get(SnapshotSummary.REMOVED_FILE_SIZE_PROP)));
Review Comment:
I would probably rewrite this assertion to
`assertThat(snapshotSummary).containsEntry(SnapshotSummary.REMOVED_FILE_SIZE_PROP,
...)` because if the assertion ever fails, you'll know what else is in the
snapshot summary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
