sebpretzer opened a new pull request, #530: URL: https://github.com/apache/iceberg-python/pull/530
Closes: https://github.com/apache/iceberg-python/issues/414 I don't know java, but tried to stay true to [the implementation](https://github.com/apache/iceberg/blob/053d54172fd903be9eda78957f3cbd3aadef1f7b/aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java#L97-L103), at least in regards to the commenting. Open Questions: 1. I did a very basic test, but I wasn't sure if I should make the test more robust in any regard. Let me know if you think of an edge case I am missing. I could test creating/listing a namespace if that would be helpful to confirm its truly working properly, but that felt like a moto issue, rather than something that should be tested within pyiceberg. 2. On my end, I am using `glue.endpoint` for all pytests. I was not sure if within pyiceberg pytests, we wanted to migrate all tests to the endpoint, or continue to use `mock_aws()`. I started with the least invasive option, but can migrate all other glue tests if that is helpful. 3. I am not seeing a ton of docs regarding glue config variables, and its is undocumented in [the main docs](https://iceberg.apache.org/docs/latest/). Within pyiceberg docs, I do see [this Glue config](https://py.iceberg.apache.org/configuration/#glue-catalog), but not sure if this is the best place to put it. Should this get added to the docs, or should it remain undocumented, since its not a commonly used feature? @Fokko @HonahX both of your thoughts or reviews would be helpful, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
