marvinlanhenke opened a new issue, #273:
URL: https://github.com/apache/iceberg-rust/issues/273

   ...perhaps I am missing something, but currently I prototype the HMS Catalog 
like: 
   ```rust
   let metadata = TableMetadataBuilder::from_table_creation(creation)?.build()?;
   let metadata_location = get_metadata_location(&location, 0)?;
   
   let file_io = FileIOBuilder::new("s3a")
       .with_props(vec![
           (S3_ENDPOINT, "http://0.0.0.0:9000".to_string()),
           (S3_ACCESS_KEY_ID, "minioadmin".to_string()),
           (S3_SECRET_ACCESS_KEY, "minioadmin".to_string()),
           (S3_REGION, "us-east-1".to_string()),
       ])
       .build()?;
   let mut file = file_io.new_output(&metadata_location)?.writer().await?;
   file.write_all(&serde_json::to_vec(&metadata)?).await?;
   file.shutdown().await?;
   ```
   
   @liurenjie1024 @Xuanwo 
   Has there been any discussions or thoughts about where to set those 
configuration params? 
   Currently I don't see anything setup - but I might be missing something?
   
   
   One way to handle this would be to pass the params (or even the complete 
FileIO) into the `HmsCatalogConfig`?
   
   ```rust
   pub struct HmsCatalogConfig {
       address: String,
       thrift_transport: HmsThriftTransport,
   }
   
   struct HmsClient(ThriftHiveMetastoreClient);
   
   /// Hive metastore Catalog.
   pub struct HmsCatalog {
       config: HmsCatalogConfig,
       client: HmsClient,
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to