nastra commented on PR #9902: URL: https://github.com/apache/iceberg/pull/9902#issuecomment-2003444989
> > there are a bunch of changes that seem unrelated to what's being proposed to be done (aka adding a check to see if blook filters are added) > > Thanks @nastra for the review. The data was written using an Avro writer, so if there is a problem with the Spark writer, the bug will not be detectable. I refecatored the tests as @amogh-jahagirdar suggested ([#9902 (comment)](https://github.com/apache/iceberg/pull/9902#discussion_r1518451041)) and I completely agree with him on this point. In that case I would probably just add a new test class where reading and writing is done through Spark. I think the purpose of `TestSparkReaderWithBloomFilter` was to actually only read through Spark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
