nastra commented on code in PR #9902:
URL: https://github.com/apache/iceberg/pull/9902#discussion_r1528034527
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderWithBloomFilter.java:
##########
@@ -95,18 +80,31 @@ public class TestSparkReaderWithBloomFilter {
protected boolean useBloomFilter;
// Schema passed to create tables
- public static final Schema SCHEMA =
- new Schema(
- Types.NestedField.required(1, "id", Types.IntegerType.get()),
- Types.NestedField.required(2, "id_long", Types.LongType.get()),
- Types.NestedField.required(3, "id_double", Types.DoubleType.get()),
- Types.NestedField.required(4, "id_float", Types.FloatType.get()),
- Types.NestedField.required(5, "id_string", Types.StringType.get()),
- Types.NestedField.optional(6, "id_boolean", Types.BooleanType.get()),
- Types.NestedField.optional(7, "id_date", Types.DateType.get()),
- Types.NestedField.optional(8, "id_int_decimal",
Types.DecimalType.of(8, 2)),
- Types.NestedField.optional(9, "id_long_decimal",
Types.DecimalType.of(14, 2)),
- Types.NestedField.optional(10, "id_fixed_decimal",
Types.DecimalType.of(31, 2)));
+ public static final StructType schema =
+ new StructType(
+ new StructField[] {
Review Comment:
why are these changes necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
