Re: [PR] Spark: Add a test to check if the bloom filters are added to the parquet files [iceberg]

[via GitHub]

nastra commented on code in PR #9902:
URL: https://github.com/apache/iceberg/pull/9902#discussion_r1528031076


##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderWithBloomFilter.java:
##########
@@ -116,54 +114,38 @@ public class TestSparkReaderWithBloomFilter {
   private static final float FLOAT_BASE = 100000F;
   private static final String BINARY_PREFIX = "BINARY测试_";
 
-  @TempDir private Path temp;
+  @TempDir private static Path temp;
 
   @BeforeEach
-  public void writeTestDataFile() throws IOException {
+  public void writeData() throws NoSuchTableException, 
TableAlreadyExistsException {
     this.tableName = "test";
-    createTable(tableName, SCHEMA);
-    this.records = Lists.newArrayList();
-
-    // records all use IDs that are in bucket id_bucket=0
-    GenericRecord record = GenericRecord.create(table.schema());
+    createTable(tableName);
+    this.rowList = Lists.newArrayList();
 
     for (int i = 0; i < INT_VALUE_COUNT; i += 1) {
-      records.add(
-          record.copy(
-              ImmutableMap.of(
-                  "id",
-                  INT_MIN_VALUE + i,
-                  "id_long",
-                  LONG_BASE + INT_MIN_VALUE + i,
-                  "id_double",
-                  DOUBLE_BASE + INT_MIN_VALUE + i,
-                  "id_float",
-                  FLOAT_BASE + INT_MIN_VALUE + i,
-                  "id_string",
-                  BINARY_PREFIX + (INT_MIN_VALUE + i),
-                  "id_boolean",
-                  i % 2 == 0,
-                  "id_date",
-                  LocalDate.parse("2021-09-05"),
-                  "id_int_decimal",
-                  new BigDecimal(String.valueOf(77.77)),
-                  "id_long_decimal",
-                  new BigDecimal(String.valueOf(88.88)),
-                  "id_fixed_decimal",
-                  new BigDecimal(String.valueOf(99.99)))));
+      Row row =

Review Comment:
   why are all these changes necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org