stevenzwu commented on code in PR #9728:
URL: https://github.com/apache/iceberg/pull/9728#discussion_r1526649078
##########
core/src/main/java/org/apache/iceberg/SnapshotsTable.java:
##########
@@ -27,7 +28,8 @@
* <p>This does not include snapshots that have been expired using {@link
ExpireSnapshots}.
*/
public class SnapshotsTable extends BaseMetadataTable {
- private static final Schema SNAPSHOT_SCHEMA =
+ @VisibleForTesting
+ static final Schema SNAPSHOT_SCHEMA =
Review Comment:
I was testing a real `StaticDataTask` for snapshot metadata table/rows.
Hence expose this as package private. Note that this is not `public` though.
We can avoid making this visible by define a custom test schema and custom
static data task in the `TestDataTaskParser`.
let me know your thoughts/preference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
