stevenzwu commented on code in PR #9728: URL: https://github.com/apache/iceberg/pull/9728#discussion_r1526491086
########## core/src/main/java/org/apache/iceberg/ScanTaskParser.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import com.fasterxml.jackson.core.JsonGenerator; +import com.fasterxml.jackson.databind.JsonNode; +import java.io.IOException; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.base.Strings; +import org.apache.iceberg.util.JsonUtil; + +public class ScanTaskParser { + private static final String TASK_TYPE = "task-type"; + + private enum TaskType { + FILE_SCAN_TASK("file-scan-task"), + DATA_TASK("data-task"); + + private final String value; + + TaskType(String value) { + this.value = value; + } + + public static TaskType fromValue(String value) { + Preconditions.checkArgument(value != null, "Task type is null"); + if (FILE_SCAN_TASK.value().equalsIgnoreCase(value)) { + return FILE_SCAN_TASK; + } else if (DATA_TASK.value().equalsIgnoreCase(value)) { + return DATA_TASK; + } else { + throw new IllegalArgumentException("Unknown task type: " + value); + } + } + + public String value() { + return value; + } + } + + private ScanTaskParser() {} + + public static String toJson(FileScanTask fileScanTask) { + Preconditions.checkArgument(fileScanTask != null, "Invalid file scan task: null"); + return JsonUtil.generate(generator -> toJson(fileScanTask, generator), false); + } + + public static FileScanTask fromJson(String json, boolean caseSensitive) { + Preconditions.checkArgument(json != null, "Invalid JSON string for file scan task: null"); + return JsonUtil.parse(json, node -> fromJson(node, caseSensitive)); + } + + private static void toJson(FileScanTask fileScanTask, JsonGenerator generator) + throws IOException { + generator.writeStartObject(); + + if (fileScanTask instanceof StaticDataTask) { + generator.writeStringField(TASK_TYPE, TaskType.DATA_TASK.value()); + DataTaskParser.toJson((StaticDataTask) fileScanTask, generator); + } else if (fileScanTask instanceof BaseFileScanTask + || fileScanTask instanceof BaseFileScanTask.SplitScanTask) { + generator.writeStringField(TASK_TYPE, TaskType.FILE_SCAN_TASK.value()); + FileScanTaskParser.toJson(fileScanTask, generator); + } else { + throw new UnsupportedOperationException( + "Unsupported task type: " + fileScanTask.getClass().getCanonicalName()); + } + + generator.writeEndObject(); + } + + private static FileScanTask fromJson(JsonNode jsonNode, boolean caseSensitive) { + TaskType taskType = TaskType.FILE_SCAN_TASK; + String taskTypeStr = JsonUtil.getStringOrNull(TASK_TYPE, jsonNode); + if (!Strings.isNullOrEmpty(taskTypeStr)) { + taskType = TaskType.fromValue(taskTypeStr); + } + + switch (taskType) { + case FILE_SCAN_TASK: + return FileScanTaskParser.fromJson(jsonNode, caseSensitive); + case DATA_TASK: + return DataTaskParser.fromJson(jsonNode); + default: + throw new UnsupportedOperationException("Unsupported task type: " + taskType.value()); Review Comment: same above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
