stevenzwu commented on code in PR #9728: URL: https://github.com/apache/iceberg/pull/9728#discussion_r1526510194
########## core/src/main/java/org/apache/iceberg/DataTaskParser.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import com.fasterxml.jackson.core.JsonGenerator; +import com.fasterxml.jackson.databind.JsonNode; +import java.io.IOException; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.util.JsonUtil; + +class DataTaskParser { + private static final String SCHEMA = "schema"; + private static final String PROJECTED_SCHEMA = "projection"; + private static final String METADATA_FILE = "metadata-file"; + private static final String ROWS = "rows"; + + private DataTaskParser() {} + + static void toJson(StaticDataTask dataTask, JsonGenerator generator) throws IOException { + Preconditions.checkArgument(dataTask != null, "Invalid data task: null"); + Preconditions.checkArgument(generator != null, "Invalid JSON generator: null"); + + generator.writeFieldName(SCHEMA); + SchemaParser.toJson(dataTask.schema(), generator); + + generator.writeFieldName(PROJECTED_SCHEMA); + SchemaParser.toJson(dataTask.projectedSchema(), generator); + + generator.writeFieldName(METADATA_FILE); + ContentFileParser.toJson(dataTask.metadataFile(), PartitionSpec.unpartitioned(), generator); + + generator.writeArrayFieldStart(ROWS); + for (StructLike row : dataTask.tableRows()) { Review Comment: I suppose it can be empty. that is fine as parser will just generate an empty array in JSON. it can't be null. we can add a null check here if that is desirable. but the StaticDataTask constructor/factory ensured non-null. ``` class StaticDataTask implements DataTask { static <T> DataTask of( InputFile metadata, Schema tableSchema, Schema projectedSchema, Iterable<T> values, Function<T, Row> transform) { return new StaticDataTask( metadata, tableSchema, projectedSchema, Lists.newArrayList(Iterables.transform(values, transform::apply)).toArray(new Row[0])); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
