nastra commented on code in PR #9945:
URL: https://github.com/apache/iceberg/pull/9945#discussion_r1526415663
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/SparkBinPackPositionDeletesRewriter.java:
##########
@@ -64,6 +64,8 @@ class SparkBinPackPositionDeletesRewriter extends
SizeBasedPositionDeletesRewrit
// Disable Adaptive Query Execution as this may change the output
partitioning of our write
this.spark = spark.cloneSession();
this.spark.conf().set(SQLConf.ADAPTIVE_EXECUTION_ENABLED().key(), false);
+ // Because we're turning off AQE we need to turn off shuffle partitions
b/c deletes rewriter makes a join later
+ this.spark.conf().set(SQLConf.SHUFFLE_PARTITIONS().key(), "1");
Review Comment:
I checked and the test you added passes for me even when this isn't being
forced to 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
