nastra commented on code in PR #9945:
URL: https://github.com/apache/iceberg/pull/9945#discussion_r1524645127
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFilesProcedure.java:
##########
@@ -119,11 +121,22 @@ public void testExpireDeleteFilesAll() throws Exception {
public void testExpireDeleteFilesNoOption() throws Exception {
createTable();
- sql("DELETE FROM %s WHERE id=1", tableName);
- sql("DELETE FROM %s WHERE id=2", tableName);
- sql("DELETE FROM %s WHERE id=3", tableName);
- sql("DELETE FROM %s WHERE id=4", tableName);
- sql("DELETE FROM %s WHERE id=5", tableName);
+ // those should be unset on procedure call
+ // if not then procedure will create not 1 but many files
+ Map<String, String> sqlConf =
Review Comment:
I think it's better to just add a new test rather than adjusting existing
tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
