amogh-jahagirdar commented on code in PR #9953:
URL: https://github.com/apache/iceberg/pull/9953#discussion_r1523786976
##########
api/src/main/java/org/apache/iceberg/io/FileIO.java:
##########
@@ -49,25 +49,25 @@ default InputFile newInputFile(String path, long length) {
default InputFile newInputFile(DataFile file) {
Preconditions.checkArgument(
file.keyMetadata() == null,
- "Cannot decrypt data file: {} (use EncryptingFileIO)",
+ "Cannot decrypt data file: %s (use EncryptingFileIO)",
file.path());
- return newInputFile(file.path().toString());
+ return newInputFile(file.path().toString(), file.fileSizeInBytes());
Review Comment:
no I confused myself, actually the default is fine. It's up to FileIO
implementations to override newInputfile with a size and keep track of the
size. That's what S3FileIO and others do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
