amogh-jahagirdar commented on code in PR #9953:
URL: https://github.com/apache/iceberg/pull/9953#discussion_r1523734039
##########
api/src/main/java/org/apache/iceberg/io/FileIO.java:
##########
@@ -51,23 +51,23 @@ default InputFile newInputFile(DataFile file) {
file.keyMetadata() == null,
"Cannot decrypt data file: {} (use EncryptingFileIO)",
file.path());
- return newInputFile(file.path().toString());
+ return newInputFile(file.path().toString(), file.fileSizeInBytes());
}
default InputFile newInputFile(DeleteFile file) {
Preconditions.checkArgument(
file.keyMetadata() == null,
"Cannot decrypt delete file: {} (use EncryptingFileIO)",
file.path());
- return newInputFile(file.path().toString());
+ return newInputFile(file.path().toString(), file.fileSizeInBytes());
}
default InputFile newInputFile(ManifestFile manifest) {
Preconditions.checkArgument(
manifest.keyMetadata() == null,
"Cannot decrypt manifest: {} (use EncryptingFileIO)",
manifest.path());
- return newInputFile(manifest.path());
+ return newInputFile(manifest.path(), manifest.length());
Review Comment:
Let me see about adding tests for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
