amogh-jahagirdar opened a new pull request, #9953:
URL: https://github.com/apache/iceberg/pull/9953

   As part of adding encryption support, in 
https://github.com/apache/iceberg/pull/9592 we added some new FileIO APIs, 
namely 
   
   ```
   newInputFile(ManifestFile)
   newInputFile(DataFile)
   newInputFile(DeleteFile)
   ```
   The overriden implementaiton in EncryptedFileIO is correct but the default 
implementation in `FileIO` for these new APIs should pass in a length since 
it's always known from the Iceberg metadata. 
   
   Without this, FileIO implementations which end up calling these default 
implementations will make extra requests to the object store/file system to 
determine the length which we can avoid. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to