TennyZhuang commented on PR #254: URL: https://github.com/apache/iceberg-rust/pull/254#issuecomment-1991016398
> Hi, @TennyZhuang Thanks for this pr! It looks great, but there are something missing: > > 1. We should try to refresh token when error happens > 2. Please make the property names constants. Hi, the implementation is mainly copied from an old python implementation about 5 months ago, which is referenced by your issue. I think the most naive implementation can make the PR easier for review. In that version you referred, token refresh is not implemented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
